Repository navigation
Wrappers: verify the published React and Vue declarations with the consumer floor compiler - #35497
Merged
EugeniyKiyashko merged 2 commits intoOct 7, 2026
Conversation
`src/core/template` resolved only through the package tsconfig baseUrl and was copied verbatim into the published cjs/core/configuration/react/templates.d.ts, where a consumer with skipLibCheck: false gets TS2307. The import is type-only, the emitted JS does not change.
…nsumer floor compiler A new verify:dts target runs the check-declarations executor over npm/cjs/**/*.d.ts with typescript-min (4.9.5), baseUrl pointing at npm/ so that workspace-only specifiers (src/..., devextreme/artifacts/npm/...) cannot resolve, and devextreme/* mapped to the built devextreme package. Wrappers Tests runs it after pack for react and vue. typescript-min becomes a devDependency of both wrappers so the executor resolves the floor compiler from the package.
EugeniyKiyashko
force-pushed
the
chore/wrappers-dts-floor-check
branch
from
October 6, 2026 09:20
4bc47da to
4113b82
Compare
EugeniyKiyashko
marked this pull request as ready for review
October 6, 2026 11:31
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The declaration checks, compiler floor, CI integration, and import correction are consistent and complete.
Review effort: Balanced
Findings: None
What changed in this PR
Adds TypeScript 4.9 compatibility checks for published React and Vue declarations.
Changes:
- Adds consumer-floor compiler dependencies and Nx verification targets.
- Runs declaration verification in wrapper CI.
- Fixes a React declaration import path.
| File | Description |
|---|---|
pnpm-lock.yaml |
Locks TypeScript 4.9.5 aliases. |
packages/devextreme-vue/project.json |
Adds Vue declaration verification. |
packages/devextreme-vue/package.json |
Adds the minimum TypeScript compiler. |
packages/devextreme-react/src/core/configuration/react/templates.ts |
Uses a publish-safe relative import. |
packages/devextreme-react/project.json |
Adds React declaration verification. |
packages/devextreme-react/package.json |
Adds the minimum TypeScript compiler. |
.github/workflows/wrapper_tests.yml |
Runs wrapper declaration checks in CI. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
r-farkhutdinov
approved these changes
Oct 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.